Skip to content

feat(medium): Styled Workout Table Implementation#9451

Draft
arii wants to merge 3 commits intoleaderfrom
styled-workout-table-18016397176237864998
Draft

feat(medium): Styled Workout Table Implementation#9451
arii wants to merge 3 commits intoleaderfrom
styled-workout-table-18016397176237864998

Conversation

@arii
Copy link
Owner

@arii arii commented Mar 3, 2026 •
edited by github-actions bot
Loading

Description

This change modernizes the workout table display by introducing a full table viewer that replaces the previous header-only view. The update includes a new WorkoutTableViewer component for a "Google Doc grid" look, enhanced typography for improved legibility, and updated data parsing to handle all table rows.

Fixes #9440

Change Type: ✨ New feature (non-breaking change adding functionality)

Changes Made

  • Styled Workout Table: Implemented WorkoutTableViewer using MUI styled components to achieve a "Google Doc grid" look with 1px solid borders and borderCollapse: 'collapse'.
  • Enhanced Typography: Increased font scale to 1.4rem for headers and 1.25rem for body cells to improve legibility in gym environments.
  • Full Data Parsing: Updated the Google Doc parsing service and DTO types to extract and transmit all table rows, not just the headers.

Testing

  • Updated parser unit tests to verify multi-row extraction.
  • Updated component unit tests to mock and verify full table rendering.
  • Updated Playwright VRT mocks and tests to ensure stable visual regression testing of the new high-density layout.

Related Issues

Closes #9440

Original PR Body

This change modernizes the workout table display by introducing a full table viewer that replaces the previous header-only view.

Key improvements:

  • Styled Workout Table: Implemented WorkoutTableViewer using MUI styled components to achieve a "Google Doc grid" look with 1px solid borders and borderCollapse: 'collapse'.
  • Enhanced Typography: Increased font scale to 1.4rem for headers and 1.25rem for body cells to improve legibility in gym environments.
  • Full Data Parsing: Updated the Google Doc parsing service and DTO types to extract and transmit all table rows, not just the headers.
  • Comprehensive Testing:
    • Updated parser unit tests to verify multi-row extraction.
    • Updated component unit tests to mock and verify full table rendering.
    • Updated Playwright VRT mocks and tests to ensure stable visual regression testing of the new high-density layout.

Fixes #9440

PR created automatically by Jules for task 18016397176237864998 started by @arii

@google-labs-jules @arii
feat: implement styled workout table with high-density grid look
b0e3241 
- Update WorkoutTableDto to include rows
- Enhance googleDocParser to extract all table rows
- Add WorkoutTableViewer component with 1.4rem headers and 1.25rem body cells
- Enforce cell borders and grid layout for WCAG compliance
- Update unit and visual regression tests to reflect changes

Co-authored-by: arii <342438+arii@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

google-labs-jules bot commented Mar 3, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@google-labs-jules google-labs-jules bot mentioned this pull request Mar 3, 2026
Open
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

👋 Welcome to HRM!

Thanks for your contribution. This repository uses Gemini AI for automated triage, code review, and generation.

🤖 Gemini Manual Trigger Quick Reference

Command Action
@gemini-bot Run AI Code Review (PR only)
@gemini-triage Run Issue Triage
@gemini-coder <task> Generate Code
@create-review-issues Create issues from review (PR only)
@gemini-help Show this help message
@pr-squash Squash PR commits (PR only)
@conflict-resolve Resolve merge conflicts (PR only)

For more details and GitHub CLI examples, see the Manual Trigger Guide.

@github-actions github-actions bot changed the title Styled Workout Table Implementation feat(medium): Styled Workout Table Implementation Mar 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

ℹ️ Gemini Review Disabled

Automatic review is currently disabled via GEMINI_ENABLE_PR_REVIEW. To run review manually:

Via Comment:

@gemini-bot

Via GitHub Actions:

  1. Go to Actions → Reusable Gemini Review
  2. Click "Run workflow"
  3. Enter PR number: 9451

Via GitHub CLI:

gh workflow run reusable-gemini-review.yml -f pr_number=9451

🤖 Manual Trigger Quick Reference

Command Action
@gemini-bot Run AI Code Review (PR only)
@gemini-triage Run Issue Triage
@gemini-coder <task> Generate Code
@create-review-issues Create issues from review (PR only)
@gemini-help Show this help message

Full reference: Manual Trigger Guide

To re-enable: Set repository variable GEMINI_ENABLE_PR_REVIEW=true

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

🤖 Gemini Review Skipped

Review was skipped for the following reason: Gemini review is disabled

🤖 Manual Trigger Quick Reference

Command Action
@gemini-bot Run AI Code Review (PR only)
@gemini-triage Run Issue Triage
@gemini-coder <task> Generate Code
@create-review-issues Create issues from review (PR only)
@gemini-help Show this help message

Manual Trigger Guide

@arii arii added the not reviewed The review could not be performed or completed successfully. label Mar 3, 2026
@google-labs-jules @arii
feat: enhance workout table header with larger font and borders
5e24e87 
- Introduce WorkoutTableViewer component for styled header-only display
- Increase header font size to 1.4rem and enforce cell borders
- Achieve high-density 'grid' look for workout instructions
- Update unit and visual regression tests for header-only structure

Co-authored-by: arii <342438+arii@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

🤖 Gemini Review Skipped

Review was skipped for the following reason: Gemini review is disabled

🤖 Manual Trigger Quick Reference

Command Action
@gemini-bot Run AI Code Review (PR only)
@gemini-triage Run Issue Triage
@gemini-coder <task> Generate Code
@create-review-issues Create issues from review (PR only)
@gemini-help Show this help message

Manual Trigger Guide

@arii arii added not reviewed The review could not be performed or completed successfully. and removed not reviewed The review could not be performed or completed successfully. labels Mar 3, 2026
@google-labs-jules @arii
feat: styled header-only workout table with larger font
a417c23 
- Introduce WorkoutTableViewer for styled header row
- Set header font to 1.4rem bold with 1px solid borders
- Adhere to header-only requirement
- Update unit tests and VRT snapshots to resolve CI mismatches

Co-authored-by: arii <342438+arii@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

🤖 Gemini Review Skipped

Review was skipped for the following reason: Gemini review is disabled

🤖 Manual Trigger Quick Reference

Command Action
@gemini-bot Run AI Code Review (PR only)
@gemini-triage Run Issue Triage
@gemini-coder <task> Generate Code
@create-review-issues Create issues from review (PR only)
@gemini-help Show this help message

Manual Trigger Guide

@arii arii added not reviewed The review could not be performed or completed successfully. and removed not reviewed The review could not be performed or completed successfully. labels Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

not reviewed The review could not be performed or completed successfully.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Styled Workout Table

1 participant

@arii