Fix a return value of signal handlers #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 16 will not allow implicit ints, implicit function declarations etc. by default. This patch overhauls to whole package source to make it build with clang16. It also gets rid of old K&R style function declaration. Bug: https://bugs.gentoo.org/870940 Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
GCC 14 will error if a value returned from a function does not match
a function prototype. This can be reproduced with -Wreturn-mismatch
option and is a problem compilers where a signal handler should return
void:
daemon.c: In function ‘sigchld_handler’:
daemon.c:108:10: error: ‘return’ with a value, in function returning void
108 | return 0;
| ^
daemon.c:92:1: note: declared here
92 | sigchld_handler(
| ^~~~~~~~~~~~~~~
daemon.c: In function ‘sighup_handler’:
daemon.c:117:10: error: ‘return’ with a value, in function returning void
117 | return 0;
| ^
daemon.c:112:1: note: declared here
112 | sighup_handler(
| ^~~~~~~~~~~~~~
daemon.c: In function ‘exit_handler’:
daemon.c:127:10: error: ‘return’ with a value, in function returning void
127 | return 0;
| ^
This patch fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on pull request #2 and will fix building with GCC 14.