Skip to content

Bugfix navigationbar size#46

Open
zhiweideng wants to merge 9 commits intoaritraroy:developfrom
zhiweideng:bugfix-navigationbar-size
Open

Bugfix navigationbar size#46
zhiweideng wants to merge 9 commits intoaritraroy:developfrom
zhiweideng:bugfix-navigationbar-size

Conversation

@zhiweideng
Copy link

What’s the problem?

  • FlashBar running in Android SDK 29, The problem is that the height of the NavigationBar is calculated incorrectly.
    Screenshot_1621500438

  • FlashBar running in Android SDK 23, Setting the bottomMargin of FlashbarContainerView does not take effect.
    Screenshot_1621500444

Solution

  • When FlashBar gravity == bottom, add FlashbarContainerView to the contentView of Activity, so that we don’t need to set the bottomMargin value of FlashbarContainerView, avoid calculating the wrong navigationBar height value and setting the bottomMargin of FlashbarContainerView unsuccessfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant