Skip to content

fix: offset and limit defaults #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ErikFerrari wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: offset and limit defaults #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/arke_server/controllers/arke_controller.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ defmodule ArkeServer.ArkeController do
load_links = Map.get(conn.query_params, "load_links", "false") == "true"
load_values = Map.get(conn.query_params, "load_values", "false") == "true"
load_files = Map.get(conn.query_params, "load_files", "false") == "true"
offset = Map.get(conn.query_params, "offset", nil)
limit = Map.get(conn.query_params, "limit", nil)
offset = Map.get(conn.query_params, "offset", 0)
limit = Map.get(conn.query_params, "limit", 100)
order = Map.get(conn.query_params, "order", [])

{count, units} =
Expand Down Expand Up @@ -276,8 +276,8 @@ defmodule ArkeServer.ArkeController do
"""
def get_groups(conn, %{"arke_id" => id}) do
project = conn.assigns[:arke_project]
offset = Map.get(conn.query_params, "offset", nil)
limit = Map.get(conn.query_params, "limit", nil)
offset = Map.get(conn.query_params, "offset", 0)
limit = Map.get(conn.query_params, "limit", 100)
order = Map.get(conn.query_params, "order", [])
arke = ArkeManager.get(id, project)

Expand Down
4 changes: 2 additions & 2 deletions lib/arke_server/controllers/group_controller.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ defmodule ArkeServer.GroupController do
project = conn.assigns[:arke_project]
member = ArkeAuth.Guardian.Plug.current_resource(conn)
permission = conn.assigns[:permission_filter] || %{filter: nil}
offset = Map.get(conn.query_params, "offset", nil)
limit = Map.get(conn.query_params, "limit", nil)
offset = Map.get(conn.query_params, "offset", 0)
limit = Map.get(conn.query_params, "limit", 100)
order = Map.get(conn.query_params, "order", [])

load_links = Map.get(conn.query_params, "load_links", "false") == "true"
Expand Down
4 changes: 2 additions & 2 deletions lib/arke_server/controllers/topology_controller.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ defmodule ArkeServer.TopologyController do
"""
def get_node(conn, %{"arke_id" => _arke_id, "arke_unit_id" => _id, "direction" => direction}) do

offset = Map.get(conn.query_params, "offset", nil)
limit = Map.get(conn.query_params, "limit", nil)
offset = Map.get(conn.query_params, "offset", 0)
limit = Map.get(conn.query_params, "limit", 100)
order = Map.get(conn.query_params, "order", [])

# TODO handle query parameter with plugs
Expand Down