ORIS entries: complete logic to push all entries to ORIS#33
ORIS entries: complete logic to push all entries to ORIS#33janzhanal wants to merge 6 commits intoarnost00:masterfrom
Conversation
|
Tesim se na tento merge. |
|
Muzu to udelat ja? V praci delam s Gitlabem, ten to ma trosku jinak, tak presne nevim... |
| if ($si) { | ||
| $params['si'] = $si; | ||
| } | ||
| if ($rentSi) { |
There was a problem hiding this comment.
neni tu potreba osefovat i moznost zmeny pujceni cipu? pokud rentSi == false, tak nastavit rent_si = 0 ?
There was a problem hiding this comment.
Spis predchystane, kdyby se to nekdy implementovalo, ted to podle me neni jak pouzit ne?
| foreach ($entries as $entry) { | ||
| if (isset($entry['ClubUserID']) && $entry['ClubUserID'] == $clubuser) { | ||
| $existingEntryId = $entry['ID']; | ||
| logMessage(" - Found existing ORIS Entry ID $existingEntryId for clubuser $clubuser during create. Switching to update."); |
There was a problem hiding this comment.
spis to otocit - napred najit, zda existuje a nasledne se rozhodnout, zda create nebo update, mame tu pak 2x stejny kod jen z druhe strany
There was a problem hiding this comment.
podle me uz obsolete
| $result=query_db("UPDATE ".TBL_ZAVXUS." SET sync_status='PENDING_DELETE' WHERE id_zavod = '$id' AND id_user = '$user_id'") | ||
| or die("Chyba při provádění dotazu do databáze."); | ||
| } else { | ||
| $result=query_db("DELETE FROM ".TBL_ZAVXUS." WHERE id_zavod = '$id' AND id_user = '$user_id'") |
There was a problem hiding this comment.
tady bude potreba zkontrolovat, co to udela s financemi!
There was a problem hiding this comment.
to by nemelo finance ovlivnit - nelze se odhlasovat po terminu prihlasek
- ale mohl by to byt corner case - oris te nenecha se odhlasit v druhem terminu, pokud ses prihlasil v prvnim
| echo $line; | ||
| // Log to file in the same directory | ||
| file_put_contents(__DIR__ . '/logs/oris_sync.log', $line, FILE_APPEND); | ||
| } |
There was a problem hiding this comment.
Log je pěkný, ale dostane se na něj jen admin serveru. Navíc nevím jak jsou filesystémy odděleny mezi instacemi/oddíly.
Spíš to zajímá správce závodů a ten by to měl najít na stránce závodu a řešit, pokud je to potřeba.
janzhanal
force-pushed
the
feature/oris-entries
branch
from
588c1cc to
965ebce
Compare
|
Dodal jsem:
Co stale visi:
|
janzhanal
changed the title
4 participants
Issue #21
Co funguje:
Co je treba dodelat: