Open
Conversation
It upgrades phpunit to a version that is aligned with Laravel 5.8 respectively.
korshoj
approved these changes
Dec 11, 2019
added 8 commits
December 11, 2019 10:41
borch-inc
approved these changes
Dec 11, 2019
madslundholmdk
approved these changes
Dec 11, 2019
clauswitt
requested changes
Dec 12, 2019
Member
clauswitt
left a comment
clauswitt
left a comment
There was a problem hiding this comment.
There is a warning in the test run (for libraries it could be an idea to make phpunit fail on warnings).
This may become a potential issue later - and is easy to fix with such a small test suite.
https://travis-ci.org/ArnsboMedia/opengraph_parser/builds/623611915#L223
Author
|
@clauswitt Nice catch, I will change it to let it fail on warnings |
ThyssenDK
approved these changes
Dec 12, 2019
added 2 commits
December 12, 2019 15:48
Instead of using annotation @expectexception, it does now call expectException() hence the annotation is deprecated.
…aph_parser into 20191211-phpunit75upg
clauswitt
approved these changes
Dec 12, 2019
added 2 commits
January 9, 2020 15:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades phpunit to version 7.5
It upgrades phpunit to a version that is aligned with Laravel 5.8 respectively.