Allow infinite and NA values to be swarmed (second version)#21
Open
billdenney wants to merge 3 commits intoaroneklund:masterfrom
Open
Allow infinite and NA values to be swarmed (second version)#21billdenney wants to merge 3 commits intoaroneklund:masterfrom
billdenney wants to merge 3 commits intoaroneklund:masterfrom
Conversation
Owner
|
Thanks! This seems to work as expected for the "swarm" and "compactswarm" methods, but has no effect on the other methods ("center", "hex", "square"). Right? I imagine most people use this package for the *swarm methods. Nevertheless, I would prefer if infinities were treated the same way regardless of method. I hope to have more time next week time to dive into this.. |
Author
|
You're right that it would not affect the other methods ("center", "hex", and "square"). And, I understand the goal to make them all work the same way. Thanks for considering it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #19
Related to eclarke/ggbeeswarm#87
This PR uses the new, internal
xToFinite()function to convert NA, -Inf, and Inf to finite values so that they can be swarmed.It replaces #20 with fewer changes.