Conversation
|
@mcguire-steve: could you please test this in linux? I'll test in Mac. @dmirota thank you for your PR! |
|
One thing I would like to ask is that the 'CONFIG' option to find_package be removed. By including this option, one explicitly requires the system to provide a .cmake file (such as protobufConfig.cmake), instead of allowing CMake to use any of a system module (under e.g. /usr/share/cmake-3.16/Modules), a user module (under HAL/cmake_modules), or a package config file (perhaps under /usr/lib/cmake//Config.cmake Requiring CONFIG requires standardized names of libraries, as well as package management to provide the Config.cmake file. The addition / use of user modules allows for different flavors of systems to be supported. To test this, I had to:
|
|
@mcguire-steve Note see: |
|
@mcguire-steve have you had any more success on this? The Mac side is still taking time but I'm getting to the bottom of it. |
|
@crheckman let me know if there is anything I could help explain. I'm happy to walk-through the build with you. |
Improvements in file reading and build