Skip to content

Update golang.org/x/image to v0.38.0 and Go to 1.26.2#18

Merged
arran4 merged 4 commits intomainfrom
update-go-and-image-15609820340488747435
Apr 15, 2026
Merged

Update golang.org/x/image to v0.38.0 and Go to 1.26.2#18
arran4 merged 4 commits intomainfrom
update-go-and-image-15609820340488747435

Conversation

@arran4
Copy link
Copy Markdown
Owner

@arran4 arran4 commented Apr 14, 2026

Update golang.org/x/image to v0.38.0 to resolve a known security vulnerability. This inherently required a Go version update. Following instructions, Go has been upgraded to 1.26.2 in go.mod, go.sum, and GitHub Action workflows.


PR created automatically by Jules for task 15609820340488747435 started by @arran4

Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version and several dependencies in go.mod. However, the reviewer identified that the Go version 1.26.2 and the versions for golang.org/x/image and golang.org/x/text are invalid. Additionally, the removal of github.com/arran4/go-subcommand appears to be an error as it is required for the project's generate commands.

Comment thread go.mod
module fontlengths

go 1.24.4
go 1.26.2
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Go version 1.26.2 is not a valid released version. The current latest stable version is 1.23.2. Please verify if this is a typo, as an invalid version in go.mod will cause the Go toolchain to fail.

Suggested change
go 1.26.2
go 1.23.2

Comment thread go.mod
github.com/arran4/golang-wordwrap v0.0.3
github.com/golang/freetype v0.0.0-20170609003504-e2365dfdc4a0
golang.org/x/image v0.33.0
golang.org/x/image v0.38.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version v0.38.0 for golang.org/x/image does not exist in the official repository (latest is v0.21.0). Please check the version number. If this is intended to fix a security vulnerability, ensure you are referencing a valid release.

Suggested change
golang.org/x/image v0.38.0
\tgolang.org/x/image v0.21.0

Comment thread go.mod
golang.org/x/mod v0.31.0 // indirect
golang.org/x/text v0.32.0 // indirect
)
require golang.org/x/text v0.35.0 // indirect
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The removal of github.com/arran4/go-subcommand is likely an error. This dependency is required for the go generate commands used in generate.go and cmd/fontlengths/main.go. Additionally, the version v0.35.0 for golang.org/x/text appears to be invalid.

require (\n\tgithub.com/arran4/go-subcommand v0.0.17 // indirect\n\tgolang.org/x/text v0.20.0 // indirect\n)

@arran4
Copy link
Copy Markdown
Owner Author

arran4 commented Apr 14, 2026

@jules delete the lint config file:

run golangci-lint
  Running [/home/runner/golangci-lint-1.64.8-linux-amd64/golangci-lint config path] in [/home/runner/work/fontlengths/fontlengths] ...
  Running [/home/runner/golangci-lint-1.64.8-linux-amd64/golangci-lint run] in [/home/runner/work/fontlengths/fontlengths] ...
  Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.26.2)
  Failed executing command with error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.26.2)
  
  Error: golangci-lint exit with code 3
  Ran golangci-lint in 91ms

And upgrade:

      - uses: actions/setup-go@v6
        with:
          go-version: go.mod
      - name: golangci-lint
        uses: golangci/golangci-lint-action@v9
        with:
          version: latest

@google-labs-jules
Copy link
Copy Markdown
Contributor

@jules delete the lint config file:

run golangci-lint
  Running [/home/runner/golangci-lint-1.64.8-linux-amd64/golangci-lint config path] in [/home/runner/work/fontlengths/fontlengths] ...
  Running [/home/runner/golangci-lint-1.64.8-linux-amd64/golangci-lint run] in [/home/runner/work/fontlengths/fontlengths] ...
  Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.26.2)
  Failed executing command with error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.26.2)
  
  Error: golangci-lint exit with code 3
  Ran golangci-lint in 91ms

And upgrade:

      - uses: actions/setup-go@v6
        with:
          go-version: go.mod
      - name: golangci-lint
        uses: golangci/golangci-lint-action@v9
        with:
          version: latest

I have updated the golangci-lint workflow as requested to use actions/setup-go@v6 and golangci/golangci-lint-action@v9. The .golangci.yml file was not present in the repository, so I did not need to delete it.

@arran4
Copy link
Copy Markdown
Owner Author

arran4 commented Apr 14, 2026

@jules remember to upgrade go:

run golangci-lint
  Running [/home/runner/golangci-lint-1.64.8-linux-amd64/golangci-lint config path] in [/home/runner/work/fontlengths/fontlengths] ...
  Running [/home/runner/golangci-lint-1.64.8-linux-amd64/golangci-lint run] in [/home/runner/work/fontlengths/fontlengths] ...
  Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.26.2)
  Failed executing command with error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.26.2)
  
  Error: golangci-lint exit with code 3
  Ran golangci-lint in 91ms

google-labs-jules Bot and others added 3 commits April 14, 2026 05:58
Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
@arran4 arran4 merged commit 4e742da into main Apr 15, 2026
7 checks passed
@arran4 arran4 deleted the update-go-and-image-15609820340488747435 branch April 15, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant