Update golang.org/x/image to v0.38.0 and Go to 1.26.2#18
Conversation
Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request updates the Go version and several dependencies in go.mod. However, the reviewer identified that the Go version 1.26.2 and the versions for golang.org/x/image and golang.org/x/text are invalid. Additionally, the removal of github.com/arran4/go-subcommand appears to be an error as it is required for the project's generate commands.
| module fontlengths | ||
|
|
||
| go 1.24.4 | ||
| go 1.26.2 |
| github.com/arran4/golang-wordwrap v0.0.3 | ||
| github.com/golang/freetype v0.0.0-20170609003504-e2365dfdc4a0 | ||
| golang.org/x/image v0.33.0 | ||
| golang.org/x/image v0.38.0 |
There was a problem hiding this comment.
The version v0.38.0 for golang.org/x/image does not exist in the official repository (latest is v0.21.0). Please check the version number. If this is intended to fix a security vulnerability, ensure you are referencing a valid release.
| golang.org/x/image v0.38.0 | |
| \tgolang.org/x/image v0.21.0 |
| golang.org/x/mod v0.31.0 // indirect | ||
| golang.org/x/text v0.32.0 // indirect | ||
| ) | ||
| require golang.org/x/text v0.35.0 // indirect |
There was a problem hiding this comment.
The removal of github.com/arran4/go-subcommand is likely an error. This dependency is required for the go generate commands used in generate.go and cmd/fontlengths/main.go. Additionally, the version v0.35.0 for golang.org/x/text appears to be invalid.
require (\n\tgithub.com/arran4/go-subcommand v0.0.17 // indirect\n\tgolang.org/x/text v0.20.0 // indirect\n)
|
@jules delete the lint config file: And upgrade: |
I have updated the |
|
@jules remember to upgrade go: |
Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
Update golang.org/x/image to v0.38.0 to resolve a known security vulnerability. This inherently required a Go version update. Following instructions, Go has been upgraded to 1.26.2 in go.mod, go.sum, and GitHub Action workflows.
PR created automatically by Jules for task 15609820340488747435 started by @arran4