forked from DBCDK/alma
-
Notifications
You must be signed in to change notification settings - Fork 1
alma #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guddo
wants to merge
219
commits into
artesis:develop
Choose a base branch
from
ding2:master
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
alma #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "right parameter name" and "extract debt_ids from params"
…n if set" This reverts commit 94934af.
It doesn't work, periodicals and holdings in general are broken by this. To make it work additional commits need to be cherry-picking to ding_availability. However, the html generating part doesn't belong in this module. This reverts commit 1919aa3. Conflicts: includes/alma.availability.inc
Alma availability regression
Actually clear the cache when alma_user_clear_cache is called
Fixes notice when there is no reservation pause in Alma
…efault_branch Fixed preferred branch default selection on reservation pop up.
…ng the field name change to 'preferred branch'
Change field_absent_id to field_alma_absent_id to matcht the other fields.
… stored in the DB
…f the module with entity_metadata_wrapper's * Updated alma fields to use virtual fields and fixed the side effect to this. * Using hook_profile2_load() to dynamic load content when needed (replaces the alters).
…from alma on inter libaray loans
Core pr 4
…lt_interest_period to get interest period.
Get default_interest period for reservations
Core pr 5
Ding2tal PR6
Some Alma installations e.g. the Copenhagen libraries return strings e.g. “Nr. 56”.
Issue 1119: Support pickup numbers which are not integers.
Issue #761 by Inlead: Consider denial of deniedRenewal a success.
Issue #1337 by Inlead: Encode special characters in item id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.