Skip to content

Conversation

@baltazorr
Copy link

  1. Now it works for several tags by single selector without additional code.
  2. Added bottom and top label positions.

@arthurgouveia
Copy link
Owner

As of now, I don't a ton of time to check everything, but I did see a few things that need a fix:

1 - No need for demo page. Use the gh-pages branch to update the live example;
2 - Don't replace the fakeCheckable for a div. An anchor is required due to accessibility.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use jQuery here? Leave it as vanillaJS.

@baltazorr
Copy link
Author

Ok, I got it.
This changes was made for my need.
In my case I have a problems with fakeCheckable a tag. If I put fakeCheckbox tag in config and leave default as a, and make another changes by your comments did you approve my pull request?

@arthurgouveia
Copy link
Owner

I'll need further reading to be sure.
On Jul 1, 2014 12:25 PM, "Bogdan Symchych" notifications@github.com wrote:

Ok, I got it.
This changes was made for my need.
In my case I have a problems with fakeCheckable a tag. If I put
fakeCheckbox tag in config and leave default as a, and make another changes
by your comments did you approve my pull request?


Reply to this email directly or view it on GitHub
#81 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants