feat: upgrade Node.js from 8.15.1 to 20.18.0 LTS (SCRUM-2)

[devin-ai-integration]

feat: upgrade Node.js from 8.15.1 to 20.18.0 LTS (SCRUM-2)

Summary

This PR upgrades the Node.js runtime from the severely outdated version 8.15.1 (EOL) to Node.js 20.18.0 LTS across both bank-client and bank-server repositories. This infrastructure upgrade enables modern dependency updates, security patches, and long-term maintainability.

Key Changes:

• Updated .nvmrc files to specify Node.js 20.18.0
• Updated package.json engines fields to require Node.js >=20.18.0
• Created missing .nvmrc file in bank-server repository
• Added missing engines field to bank-server package.json
• Regenerated yarn.lock files with Node.js 20.18.0 and Yarn 1.22.22
• Upgraded from Node.js 8.x to 20.x (4+ major version jump)

Review & Testing Checklist for Human

⚠️ HIGH RISK - 5 critical items to verify:

• Full functional testing: Test all core banking features (authentication, account management, transactions, dashboard) in both development and production modes to ensure no runtime compatibility issues
• Production build verification: Run yarn build and test production builds for both client and server to ensure webpack/TypeScript compilation issues don't break deployment
• Fresh environment testing: Test the upgrade on a clean environment (rm -rf node_modules && yarn install) to simulate new developer setup and catch any missing dependencies
• Security dependency review: Review the regenerated yarn.lock files for any new security vulnerabilities or concerning dependency version changes
• Performance regression testing: Verify that application startup time and runtime performance haven't regressed with the new Node.js version

Recommended Test Plan:

1. Test user registration/login flow
2. Test account balance calculations and transaction history
3. Test dashboard rendering and real-time updates
4. Verify API endpoints respond correctly
5. Test error handling and edge cases

---

Diagram

%%{ init : { "theme" : "default" }}%%
graph TB
    subgraph "bank-client"
        ClientNvmrc[".nvmrc<br/>lts/dubnium → 20.18.0"]:::major-edit
        ClientPkg["package.json<br/>engines: >=8.15.1 → >=20.18.0"]:::major-edit
        ClientLock["yarn.lock<br/>(regenerated)"]:::major-edit
    end
    
    subgraph "bank-server"
        ServerNvmrc[".nvmrc<br/>(created: 20.18.0)"]:::major-edit
        ServerPkg["package.json<br/>(added engines field)"]:::major-edit
        ServerLock["yarn.lock<br/>(regenerated)"]:::major-edit
    end
    
    subgraph "Runtime Environment"
        NodeJS["Node.js Runtime<br/>8.15.1 → 20.18.0"]:::context
        Yarn["Yarn Package Manager<br/>1.22.22"]:::context
    end
    
    ClientNvmrc --> NodeJS
    ServerNvmrc --> NodeJS
    ClientPkg --> NodeJS
    ServerPkg --> NodeJS
    ClientLock --> Yarn
    ServerLock --> Yarn
    
    subgraph Legend
        L1[Major Edit]:::major-edit
        L2[Minor Edit]:::minor-edit
        L3[Context/No Edit]:::context
    end
    
    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB
    classDef context fill:#FFFFFF

Loading

Notes

Compatibility Issues Observed:

• Client application requires NODE_OPTIONS="--openssl-legacy-provider" due to webpack 4.x compatibility issues with Node.js 20.x
• Server shows TypeScript compilation errors (393 errors) related to type definition compatibility, though application starts successfully
• Both applications start and run, but build-time errors suggest potential production deployment issues

Testing Performed:

• Verified both applications start successfully with Node.js 20.18.0
• Confirmed yarn.lock regeneration completed without errors
• Basic startup testing only - comprehensive functional testing required

Session Details:

• Devin session: https://app.devin.ai/sessions/f536c416ddfb4d29a3b384fe02330fc3
• Requested by: Arthur Poon (@akkp-windsurf)
• JIRA ticket: SCRUM-2

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring