Upgrade Node.js to 18.20.8 LTS#3
Open
devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
Open
Conversation
- Update .nvmrc from lts/dubnium to 18.20.8 - Update package.json engines field to require Node.js >=18.0.0 - Update README.md system requirements to Node.js v18.20+ - Note: offline-plugin compatibility issue with Node.js 18.x needs resolution Co-Authored-By: Arthur Poon <arthur.poon@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Disable offline-plugin due to Node.js 18/20 compatibility issues - Add --openssl-legacy-provider flag for Webpack 4.x compatibility - Production build now works successfully with Node.js 18.20.8 Co-Authored-By: Arthur Poon <arthur.poon@windsurf.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Node.js runtime from >=8.15.1 to 18.x LTS
Summary
This PR upgrades the Node.js runtime requirements from the legacy >=8.15.1 to Node.js 18.20+ (LTS) across both bank-client and bank-server repositories. The upgrade required several compatibility workarounds due to the significant version jump and aging dependencies.
Key Changes:
package.jsonengines field to requirenode: ">=18.0.0".nvmrcfiles to specify Node.js18.20.8v18.20+system requirementsoffline-plugindue to Node.js 18/20 compatibility issuesNODE_OPTIONS=--openssl-legacy-providerflag to build script for Webpack 4.x compatibilityenginesfield to package.jsonReview & Testing Checklist for Human
offline-pluginwas disabled rather than updated. Confirm this doesn't break critical functionality or consider finding an alternative solution--openssl-legacy-providerworkaround doesn't cause issues in production environmentsRecommended Test Plan:
.nvmrcfilesyarn install && yarn buildin both repositoriesDiagram
%%{ init : { "theme" : "default" }}%% graph TB subgraph bank-client["bank-client Repository"] client-pkg["package.json<br/>(engines: node >=18.0.0)"]:::major-edit client-nvmrc[".nvmrc<br/>(18.20.8)"]:::major-edit client-readme["README.md<br/>(v18.20+ requirement)"]:::minor-edit webpack["webpack.prod.babel.js<br/>(disabled offline-plugin)"]:::major-edit end subgraph bank-server["bank-server Repository"] server-pkg["package.json<br/>(added engines field)"]:::major-edit server-nvmrc[".nvmrc<br/>(18.20.8)"]:::major-edit server-readme["README.md<br/>(v18.20+ requirement)"]:::minor-edit end nodejs["Node.js 18.20.8 LTS"]:::context client-nvmrc --> nodejs server-nvmrc --> nodejs client-pkg --> nodejs server-pkg --> nodejs webpack -.-> |"compatibility issue"| nodejs subgraph Legend L1["Major Edit"]:::major-edit L2["Minor Edit"]:::minor-edit L3["Context/No Edit"]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
offline-pluginissue affects PWA functionality and should be addressed in a follow-up if offline capabilities are requiredSession Details: