feat: upgrade Node.js from 8.15.1+ to 18.20.8 LTS#4
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
feat: upgrade Node.js from 8.15.1+ to 18.20.8 LTS#4devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Update .nvmrc to specify Node.js 18.20.8 - Update package.json engines field to require >=18.0.0 - Update README.md system requirements to Node.js v18.20+ - Maintain compatibility with existing webpack 4.44.0 and build tools - Requires NODE_OPTIONS='--openssl-legacy-provider' for webpack 4.x compatibility Co-Authored-By: Arthur Poon <arthur.poon@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: upgrade Node.js from 8.15.1+ to 18.20.8 LTS
Summary
Upgrades the Node.js version requirement from 8.15.1+ to 18.20.8 LTS to modernize the development environment and improve security. This is a significant version jump that required testing webpack 4.x compatibility with newer Node.js versions.
Key Changes:
.nvmrcfrom "lts/dubnium" (Node 10.x) to "18.20.8"package.jsonengines field from ">=8.15.1" to ">=18.0.0"Compatibility Notes:
NODE_OPTIONS="--openssl-legacy-provider"for webpack 4.x compatibility with Node 18+Review & Testing Checklist for Human
🔴 Critical (3 items):
yarn start,yarn build, andyarn testwithNODE_OPTIONS="--openssl-legacy-provider"in different environmentsTest Plan:
nvm use 18.20.8yarn installexport NODE_OPTIONS="--openssl-legacy-provider" && yarn startexport NODE_OPTIONS="--openssl-legacy-provider" && yarn buildDiagram
%%{ init : { "theme" : "default" }}%% graph TD A[".nvmrc<br/>(Node 18.20.8)"]:::major-edit B["package.json<br/>(engines: >=18.0.0)"]:::major-edit C["README.md<br/>(v18.20+ requirement)"]:::minor-edit D["webpack.base.babel.js<br/>(build configuration)"]:::context E["webpack.dev.babel.js<br/>(dev server)"]:::context F["webpack.prod.babel.js<br/>(production build)"]:::context G["yarn.lock<br/>(dependencies)"]:::context H["babel.config.js<br/>(transpilation)"]:::context A --> D B --> G G --> D D --> E D --> F H --> E H --> F subgraph Legend L1["Major Edit"]:::major-edit L2["Minor Edit"]:::minor-edit L3["Context/No Edit"]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
NODE_OPTIONS="--openssl-legacy-provider"flag is necessary because webpack 4.x uses legacy OpenSSL algorithms that were removed in Node.js 17+. This is a known compatibility issue.Link to Devin run: https://app.devin.ai/sessions/a21bbed4d897417c9ae368473d68c6fd
Requested by: Arthur Poon (@akkp-windsurf)