New Feature: Automatically load and save application preferences using GSettings#33
New Feature: Automatically load and save application preferences using GSettings#33mlaga97 wants to merge 2 commits intoartizirk:masterfrom
Conversation
|
Would it be possible to make this optional at build time? |
Correct me if I've missed it, but this project does not currently have an existing build flag / feature flag system that I am aware of to build upon (please correct me if I missed it) and adding a build flag system to the project does seem out of scope to this PR. If a particular feature flag system already exists in the project or is decided upon, it shouldn't be difficult to gate this feature behind that. |
|
I do have to ask because I am curious, why do you want a build-time setting to disable runtime settings? I'm mostly wondering if there an underlying issue that you are running into with this implementation that should be addressed more directly before merging. |
|
Regarding feature flags, they are handled by the meson build system and can be defined in meson.options However you're right to ask why: I got things mixed up in my mind and thought for a moment that Gsettings where GNOME extensions and not part of core GTK... |
|
I just noticed that you didn't provide licensing information for the file you added. You can do so in .reuse/dep5 or by adding a comment header like so: <?xml version="1.0" encoding="utf-8"?>
<!--
SPDX-FileCopyrightText: 2026 <Firstname> <Lastname>
SPDX-License-Identifier: <license>
-->
<schemalist> |
Adds a GSettings schema and appropriate hooks to load and save hamburger menu preferences between runs.