Allow applying pending changes with Ctrl+Return#35
Open
0x17de wants to merge 1 commit intoartizirk:masterfrom
Open
Allow applying pending changes with Ctrl+Return#350x17de wants to merge 1 commit intoartizirk:masterfrom
0x17de wants to merge 1 commit intoartizirk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, pressing Return in a form field stages the change but does not apply it to the compositor - the user must reach for the Apply button with the mouse. This adds Ctrl+Return as a keyboard shortcut to apply pending changes immediately, without leaving the keyboard.
The shortcut is only active while the "Apply" button is shown, so it is a no-op when there is nothing pending. The implementation follows the same pattern as the existing Ctrl+−/0/+ zoom shortcuts: a single element on the button in wdisplays.ui.