Add example flows (top-level) / (metacrate) by oleksandrvoyager · Pull Request #24 · artob/protoflow

oleksandrvoyager · 2024-11-26T05:31:54Z

No description provided.

SamuelSarle

LGTM although for some reason I'm unable to run these:

examples/csv_roundtrip.rs
examples/hash_content.rs
examples/log_directories.rs

Were you able to run those? They give import errors that I haven't been able to solve for TextBlocks::concat_strings_by, TextBlocks::decode_csv, TextBlocks::encode_csv, and HashBlocks::hash_sha2.
Specifically that would be the implementations missing for protoflow_blocks::System but of course all of those are present in the repo (lib/protoflow-blocks/src/system.rs)

Examples:

error[E0599]: no method named `encode_csv` found for mutable reference `&mut protoflow::protoflow_blocks::System` in the current scope
error[E0599]: no method named `decode_csv` found for mutable reference `&mut protoflow::protoflow_blocks::System` in the current scope
error[E0599]: no method named `hash_sha2` found for mutable reference `&mut protoflow::protoflow_blocks::System` in the current scope
error[E0599]: no method named `concat_strings_by` found for mutable reference `&mut protoflow::protoflow_blocks::System` in the current scope

lib/protoflow/examples/process_env_var/main.rs

SamuelSarle · 2024-12-12T12:18:05Z

lib/protoflow/examples/json_processing/main.rs

+        let json = s.const_string(r#"{"Name": "Alice","Age": 25,"Score": 90}"#);
+
+        let line_encoder = s.encode_lines();
+        s.connect(&json.output, &line_encoder.input);


In the future we should probably implement a Const helper which can output Bytes from a string. This behaves correctly but the line_encoder looks a bit funny here :)

SamuelSarle · 2024-12-12T12:22:52Z

lib/protoflow/examples/encode_hex/main.rs

+        let input_string = s.const_string("The quick brown fox jumps over the lazy dog");
+
+        let encoder = s.encode_lines();
+        s.connect(&input_string.output, &encoder.input);


Likewise for here as hex("$string\n") != hex("$string")

SamuelSarle · 2024-12-12T15:07:46Z

lib/protoflow/examples/decode_hex/main.rs

+        let input_string = s.const_string("54686520717569636b2062726f776e20666f78206a756d7073206f76657220746865206c617a7920646f670a");
+
+        let encoder = s.encode_lines();
+        s.connect(&input_string.output, &encoder.input);
+
+        let hex_decoder = s.decode_hex();
+        s.connect(&encoder.output, &hex_decoder.input);


Same problem, with interesting behaviour with DecodeHex! This appends a newline at the end before sending it to DecodeHex which should result in an error. But DecodeHex uses Bytes::chunks_exact(2) which leaves the newline character alone as it's one byte:

The chunks are slices and do not overlap. If chunk_size does not divide the length of the
slice, then the last up to chunk_size-1 elements will be omitted and can be retrieved
from the remainder function of the iterator.

I think that DecodeHex shouldn't accept and ignore the last byte silently so we should make a PR so that it checks the content length is divisible by two.

SamuelSarle · 2024-12-12T20:46:08Z

examples/hash_content.rs

+        let content = s.const_string("Hello, World!");
+        let line_encoder = s.encode_lines();
+        let hash_content = s.hash_sha2();


Not able to run this file directly but copying the code to somewhere else you get

$ echo "Hello, World!" | sha256sum c98c24b677eff44860afea6f493bbaec5bb1c4cbb209c6fc2bbb47f66ff2ad31

instead of the correct

$ echo -n "Hello, World!" | sha256sum dffd6021bb2bd5b0af676290809ec3a53191dd81c7f70a4b28688a362182986f

due to the s.encode_lines() adding a newline that also gets hashed.

examples/hash_content.rs

Co-authored-by: Samuel Sarle <samuel@sarle.com> Signed-off-by: Oleksandr Yakovenko <35838571+AlexSanches1@users.noreply.github.com>

artob · 2025-01-27T21:31:15Z

@race-of-sloths invite

race-of-sloths · 2025-01-27T21:32:15Z

@oleksandrvoyager Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

Current status: stale

This pull request was removed from the race, but you can include it again with @race-of-sloths include command

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

Tag @race-of-sloths inside your pull requests
Wait for the maintainer to review and score your pull request
Check out your position in the Leaderboard
Keep weekly and monthly streaks to reach higher positions
Boast your contributions with a dynamic picture of your Profile

For maintainers:

Score pull requests that participate in the Race of Sloths and receive a reward
Engage contributors with fair scoring and fast responses so they keep their streaks
Promote the Race to the point where the Race starts promoting you
Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

For contributors
- Include a PR: @race-of-sloths include to enter the Race with your PR
For maintainers:
- Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
- Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
- Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
- Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

github-actions

⚠️ CI failed

Platform	Name	Status	Details
All	Formatting	✅	Details
Linux	Build library	❌	Details
Linux	Build binaries	❌	Details
Linux	Build tests	❌	Details
Linux	Build examples	❌	Details
Linux	Run tests	⏩	Details
Linux	Run doctests	⏩	Details

artob · 2026-01-22T22:43:25Z

@race-of-sloths score 13

github-actions

⚠️ CI failed

Platform	Name	Status	Details
All	Formatting	✅	Details
Linux	Build library	❌	Details
Linux	Build binaries	❌	Details
Linux	Build tests	❌	Details
Linux	Build examples	❌	Details
Linux	Run tests	⏩	Details
Linux	Run doctests	⏩	Details

artob · 2026-01-22T22:58:17Z

Important

Protoflow has been discontinued and archived in favor of its successors Async-Flow and Flows.rs, which represent the future of flow-based programming in Rust and offer a substantially better developer experience as well as simply higher development velocity. We aim to eventually port the functionality in this pull request over to Flows.rs; if you'd like to contribute to make that happen sooner, please raise an issue and/or pull request against that repository.

Add example flows (top-level) WIP

f8f74a5

oleksandrvoyager self-assigned this Nov 26, 2024

oleksandrvoyager requested a review from artob as a code owner November 26, 2024 05:31

Add more couple of examples

bcb3597

oleksandrvoyager requested review from SamuelSarle, evren-okcu, imunproductive and joshuajbouw November 27, 2024 06:02

Add example flows (metacrate)

8c0da7c

oleksandrvoyager changed the title ~~Add example flows (top-level)~~ Add example flows (top-level)/(metacrate) Nov 29, 2024

oleksandrvoyager changed the title ~~Add example flows (top-level)/(metacrate)~~ Add example flows (top-level) / (metacrate) Nov 29, 2024

oleksandrvoyager assigned artob and unassigned oleksandrvoyager Nov 29, 2024

oleksandrvoyager and others added 2 commits December 3, 2024 14:39

Fixes by cargo fmt

04e2117

Merge branch 'master' into alex/examples

5d6fe4f

github-actions bot approved these changes Dec 4, 2024

View reviewed changes

SamuelSarle approved these changes Dec 12, 2024

View reviewed changes

SamuelSarle reviewed Dec 12, 2024

View reviewed changes

examples/hash_content.rs Outdated Show resolved Hide resolved

SamuelSarle mentioned this pull request Dec 12, 2024

Add a protoflow_blocks::System::const_bytes helper #30

Merged

Update lib/protoflow/examples/process_env_var/main.rs

38803ff

Co-authored-by: Samuel Sarle <samuel@sarle.com> Signed-off-by: Oleksandr Yakovenko <35838571+AlexSanches1@users.noreply.github.com>

github-actions bot approved these changes Dec 13, 2024

View reviewed changes

Update examples/hash_content.rs

5a31983

Co-authored-by: Samuel Sarle <samuel@sarle.com> Signed-off-by: Oleksandr Yakovenko <35838571+AlexSanches1@users.noreply.github.com>

github-actions bot approved these changes Dec 13, 2024

View reviewed changes

oleksandrvoyager assigned oleksandrvoyager and unassigned artob Dec 13, 2024

Merge branch 'master' into alex/examples

63981ee

github-actions bot suggested changes Jan 22, 2026

View reviewed changes

Merge branch 'master' into alex/examples

e36d867

github-actions bot suggested changes Jan 22, 2026

View reviewed changes

artob closed this Jan 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add example flows (top-level) / (metacrate)#24

Add example flows (top-level) / (metacrate)#24
oleksandrvoyager wants to merge 9 commits intomasterfrom
alex/examples

oleksandrvoyager commented Nov 26, 2024

Uh oh!

SamuelSarle left a comment

Uh oh!

Uh oh!

SamuelSarle Dec 12, 2024

Uh oh!

SamuelSarle Dec 12, 2024

Uh oh!

SamuelSarle Dec 12, 2024

Uh oh!

SamuelSarle Dec 12, 2024

Uh oh!

Uh oh!

artob commented Jan 27, 2025

Uh oh!

race-of-sloths commented Jan 27, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

artob commented Jan 22, 2026

Uh oh!

github-actions bot left a comment

Uh oh!

artob commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

oleksandrvoyager commented Nov 26, 2024

Uh oh!

SamuelSarle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SamuelSarle Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

SamuelSarle Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

SamuelSarle Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

SamuelSarle Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

artob commented Jan 27, 2025

Uh oh!

race-of-sloths commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ CI failed

Uh oh!

artob commented Jan 22, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ CI failed

Uh oh!

artob commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

race-of-sloths commented Jan 27, 2025 •

edited

Loading