Conversation
4ebc035 to
85af8a6
Compare
50647e8 to
0f5c529
Compare
|
Currently CI fails due to this PR's new dependency on |
imunproductive
left a comment
There was a problem hiding this comment.
Some nit-picks that I've noticed while I was fixing CI. Didn't look thoroughly at the rest of the code but at the first glance looks good to me.
There was a problem hiding this comment.
This file is auto-generated. Maybe it makes more sense to put it in generated/-like directory and add it to .gitignore?
There was a problem hiding this comment.
I explicitly configure prost-build in build.rs to output the generated files to src/ as by default they go to the build directory (target/.../) and are imported with include!(concat!(env!("OUT_DIR"), "/your.proto.package.rs")).
So unless we have a preference against it, I'd place this in src/ and commit the generated file.
|
@race-of-sloths invite |
|
@artob Thank you for calling! @SamuelSarle Thank you for the contribution! Join Race of Sloths by simply mentioning me in your comment/PRs description and start collecting Sloth Points through contributions to open source projects. What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
|
Important Protoflow has been discontinued and archived in favor of its successors Async-Flow and Flows.rs, which represent the future of flow-based programming in Rust and offer a substantially better developer experience as well as simply higher development velocity. We aim to eventually port the functionality in this pull request over to Flows.rs; if you'd like to contribute to make that happen sooner, please raise an issue and/or pull request against that repository. |
No description provided.