Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Change how system.rs imports blocks to avoid merge conflicts#39

Closed
imunproductive wants to merge 4 commits intoartob:masterfrom
imunproductive:fix/system-use
Closed

Change how system.rs imports blocks to avoid merge conflicts#39
imunproductive wants to merge 4 commits intoartob:masterfrom
imunproductive:fix/system-use

Conversation

@imunproductive
Copy link
Contributor

This PR fixes potential merge conflicts in other PR's by removing including blocks by name in system.rs and using block mod that I implemented.

Just doing

use crate::{
	*,
	prelude::{fmt, Arc, Box, Bytes, FromStr, Rc, String, ToString},
    types::{DelayType, Encoding},
}

would also suffice, but I don't like just including everything.

This seems like a good solution, considering that we will be refactoring the way we include modules soon either way.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ CI failed

Platform Name Status Details
All Formatting Details
Linux Build library Details
Linux Build binaries Details
Linux Build tests Details
Linux Build examples Details
Linux Run tests Details
Linux Run doctests Details

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ CI failed

Platform Name Status Details
All Formatting Details
Linux Build library Details
Linux Build binaries Details
Linux Build tests Details
Linux Build examples Details
Linux Run tests Details
Linux Run doctests Details

@imunproductive imunproductive added the enhancement New feature or request label Dec 26, 2024
@artob
Copy link
Owner

artob commented Jan 27, 2025

@race-of-sloths invite

@race-of-sloths
Copy link

race-of-sloths commented Jan 27, 2025

@imunproductive Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Are you going to win race-of-sloths this month? If so, you should speed up! Run, Sloth, run!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: stale

This pull request was removed from the race, but you can include it again with @race-of-sloths include command

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ CI failed

Platform Name Status Details
All Formatting Details
Linux Build library Details
Linux Build binaries Details
Linux Build tests Details
Linux Build examples Details
Linux Run tests Details
Linux Run doctests Details

@artob
Copy link
Owner

artob commented Jan 22, 2026

@race-of-sloths score 5

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ CI failed

Platform Name Status Details
All Formatting Details
Linux Build library Details
Linux Build binaries Details
Linux Build tests Details
Linux Build examples Details
Linux Run tests Details
Linux Run doctests Details

@artob
Copy link
Owner

artob commented Jan 22, 2026

Important

Protoflow has been discontinued and archived in favor of its successors Async-Flow and Flows.rs, which represent the future of flow-based programming in Rust and offer a substantially better developer experience as well as simply higher development velocity.

@artob artob closed this Jan 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants