Add traits feature for dogma dependency in protoflow-core#42
Conversation
|
@race-of-sloths invite |
|
@SamuelSarle Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 3! @artob received 25 Sloth Points for reviewing and scoring this pull request. Another weekly streak completed, well done @SamuelSarle! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
|
@race-of-sloths score 3 |
protoflow-coredepends ondogmaversion0.1which by default pulls the latest0.1.8.protoflow-corethen uses thetraitsmodule here:https://github.com/asimov-platform/protoflow/blob/0cda080fc559c14361cd83c6ffb4b1b99ef06150/lib/protoflow-core/src/prelude.rs#L62
But
dogmahas feature-gated that behindtraitssince around0.1.3:dogmatists/dogma.rs@eeb838c
The error:
Outcomes:
rm Cargo.lock && cargo check, your lockfile—like mine—probably has a version with which everything here seems to be fine)protoflow-coreare also broken if they neither pindogma = "=0.1.2"in theirCargo.tomlnor have a lockfile with<0.1.3