Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Add traits feature for dogma dependency in protoflow-core#42

Merged
artob merged 1 commit intomasterfrom
samuel/fix-dogma-dep
May 31, 2025
Merged

Add traits feature for dogma dependency in protoflow-core#42
artob merged 1 commit intomasterfrom
samuel/fix-dogma-dep

Conversation

@SamuelSarle
Copy link
Contributor

protoflow-core depends on dogma version 0.1 which by default pulls the latest 0.1.8.
protoflow-core then uses the traits module here:
https://github.com/asimov-platform/protoflow/blob/0cda080fc559c14361cd83c6ffb4b1b99ef06150/lib/protoflow-core/src/prelude.rs#L62

But dogma has feature-gated that behind traits since around 0.1.3:
dogmatists/dogma.rs@eeb838c

The error:

error[E0432]: unresolved import `dogma::traits`
  --> lib/protoflow-core/src/prelude.rs:62:16
   |
62 | pub use dogma::traits::{Labeled, MaybeLabeled, MaybeNamed, Named};
   |                ^^^^^^ could not find `traits` in `dogma`
   |
note: found an item that was configured out
  --> ~/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/dogma-0.1.8/src/lib.rs:36:9
   |
36 | pub mod traits;
   |         ^^^^^^
note: the item is gated here
  --> ~/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/dogma-0.1.8/src/lib.rs:27:1
   |
27 | / #[cfg(any(
28 | |     feature = "traits",
29 | |     any(
30 | |         feature = "collection",
...  |
35 | | ))]
   | |___^

Outcomes:

  1. A clean checkout of this repo fails (you can also see this by doing rm Cargo.lock && cargo check, your lockfile—like mine—probably has a version with which everything here seems to be fine)
  2. Crates that depend on protoflow-core are also broken if they neither pin dogma = "=0.1.2" in their Cargo.toml nor have a lockfile with <0.1.3

@SamuelSarle
Copy link
Contributor Author

@race-of-sloths invite

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ CI failed

Platform Name Status Details
All Formatting Details
Linux Build library Details
Linux Build binaries Details
Linux Build tests Details
Linux Build examples Details
Linux Run tests Details
Linux Run doctests Details

@race-of-sloths
Copy link

race-of-sloths commented May 31, 2025

@SamuelSarle Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@artob 3

Your contribution is much appreciated with a final score of 3!
You have received 50 (30 base + 20 weekly bonus) Sloth points for this contribution

@artob received 25 Sloth Points for reviewing and scoring this pull request.

Another weekly streak completed, well done @SamuelSarle! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@artob artob added the enhancement New feature or request label May 31, 2025
@artob
Copy link
Owner

artob commented May 31, 2025

@race-of-sloths score 3

@artob artob merged commit c2e19e8 into master May 31, 2025
2 of 3 checks passed
@artob artob deleted the samuel/fix-dogma-dep branch May 31, 2025 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants