Merged
Conversation
Cover default output path, single- and multi-file AST, codegen guard, invalid link_mode, main detection, and show_ast fallbacks.
There was a problem hiding this comment.
Pull request overview
Adds targeted unit tests to cover previously untested edge-case branches in arx.main.ArxMain, improving line/branch coverage for src/arx/main.py as requested in issue #40.
Changes:
- Add tests for
_resolve_output_file,_get_astx(single-file),_get_codegen_astxmulti-module guard,_has_main_entryoverModuleandBlock. - Add tests for
run()invalidlink_modevalidation. - Add tests for
show_ast()error/fallback behavior, includingto_jsonpreference and_format_ast_fallbackcoverage (simple values, cycles, and “exotic” fields).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Satisfy mypy override checks for test AST subclasses; drop unused type ignore.
Use setattr to stub _get_astx for CI mypy strict.
xmnlab
approved these changes
Apr 5, 2026
Contributor
|
Thanks @omsherikar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover default output path, single- and multi-file AST, codegen guard, invalid link_mode, main detection, and show_ast fallbacks.
solves #40