Suggested changes (code untested) to tutorial. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## Wait for all tasks to finish | ||
| for i, task_id in enumerate(task_ids): | ||
| while True: | ||
| file_to_result = {} |
There was a problem hiding this comment.
It took me reading this loop 3 times to understand why this might be more performant. I guess now we're circling through each of the tasks more frequently so we might increase our chances of "catching" one that's completed and adding its result into the completed list earlier. Although I'm unconvinced that "catching" a completed task earlier and adding its results to the results map earlier is really going to be much more performant, unless I'm missing something.
Also, I'm not convinced that a more efficient code is preferred to easier to understand code in a tutorial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.