Prepare stat rolls using roll data in a dedicated chat message#55
Open
teroparvinen wants to merge 3 commits intoasacolips-projects:mainfrom
Open
Prepare stat rolls using roll data in a dedicated chat message#55teroparvinen wants to merge 3 commits intoasacolips-projects:mainfrom
teroparvinen wants to merge 3 commits intoasacolips-projects:mainfrom
Conversation
4d2e234 to
64c3d8a
Compare
Contributor
Author
|
Here's a more polished version.
|
a00465a to
679a0b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a proof of concept MVP version of having stat rolls be configurable using a chat message to house the data for the roll. This is still quite rough around the edges, but should illustrate the principle.
Features:
Holding down shift when clicking the character sheet stat roll button uses the old flow for comparison.
Limitations: