Add TextMany support to PbtA system - multi-single-line text attribute type [draft PR for discussion only]#286
Draft
richardgaywood wants to merge 10 commits intoasacolips-projects:mainfrom
Draft
Conversation
added 8 commits
April 6, 2025 14:37
Author
|
Hey @mclemente ! I got this proof of concept working for my use case. If you're interested in merging it, I can finish cleaning it up (there's some dead comments), and I can add better code to handle actor data migration when the sheet config changes (right now it clears the entire attribute but it could do a better job to preserve data.) Let me know what you want to do! I'd be very happy to do the work to contribute the changes, so I don't need to maintain a fork indefinitely. Here's how it looks in the sheet, FYI: |
richardgaywood
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #pbta, this is an early attempt at supporting a new attribute type: a group of single lines of text. It's faster to edit than a LongText as there's not TinyMCE UX cluttering it up, but it allows the tracking / editing / clearing of multiple plain text values at once. My primary use case is Conditions in Public Access, but I am sure there are others.