Improving performance when verifying 1000s of files in one history#159
Closed
ptrpfn wants to merge 1 commit intoascmitc:masterfrom
Closed
Improving performance when verifying 1000s of files in one history#159ptrpfn wants to merge 1 commit intoascmitc:masterfrom
ptrpfn wants to merge 1 commit intoascmitc:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves performance when verifying a large number of files by limiting a costly I/O check to scenarios involving renaming.
- Introduces a condition to execute the expensive check only when renaming is detected.
- Bypasses the check otherwise, directly adding the file path to the new paths set.
Comments suppressed due to low confidence (1)
ascmhl/commands.py:257
- Consider computing existing_history.get_relative_file_path(file_path) once before the loop to avoid redundant filesystem access inside the loop.
if media_hash.path == existing_history.get_relative_file_path(file_path):
Collaborator
|
covered by pull request #166 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limiting a costly check to the renaming scenarios where it's needed.
The symptom was that the I/O speed on fast drives (for example, during the
createcommand) got slower and slower after 1000s of files verified. This now only happens when the-droption is set (where it's needed).No tests have been changed.