Skip to content

Correctly buffer input/output streams for files #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented May 29, 2025

This will provide a slight performance improvement on very large input/output files that are being analysed by the build process.

This will provide a slight performance improvement on very large
input/output files that are being analysed by the build process.
@ascopes ascopes self-assigned this May 29, 2025
@ascopes ascopes added bug Something isn't working chore General tech debt work. labels May 29, 2025
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (03489a5) to head (068ea16).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   91.95%   91.91%   -0.03%     
==========================================
  Files          56       56              
  Lines        1675     1667       -8     
  Branches      104      105       +1     
==========================================
- Hits         1540     1532       -8     
  Misses         99       99              
  Partials       36       36              
Files with missing lines Coverage Δ
...thub/ascopes/protobufmavenplugin/fs/FileUtils.java 100.00% <100.00%> (ø)
...pes/protobufmavenplugin/fs/UriResourceFetcher.java 100.00% <100.00%> (ø)
...protobufmavenplugin/plugins/JvmPluginResolver.java 83.34% <100.00%> (+0.11%) ⬆️
...otobufmavenplugin/sources/ProtoSourceResolver.java 81.18% <100.00%> (ø)
...n/sources/incremental/IncrementalCacheManager.java 91.14% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ascopes ascopes merged commit a333e2e into main May 29, 2025
15 checks passed
@ascopes ascopes deleted the bugfix/buffer-files branch May 29, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore General tech debt work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant