Skip to content

Conversation

@mattp0
Copy link
Contributor

@mattp0 mattp0 commented Sep 2, 2025

Pull Request Checklist

I have:

  • performed a self review of my code I&A code style
    • Resources and Data Structures are sorted by ABC or a defined sorting pattern
  • updated the documentation accordingly
  • verified required action checks are passing
  • bumped the version number as appropriate

@mattp0 mattp0 changed the title PR- 7027 add h5 attribute syntax PR-7027 add h5 attribute syntax Sep 2, 2025
@mattp0 mattp0 force-pushed the mrp/feature/add-attribute-to-h5key branch 4 times, most recently from fdb368c to 819540a Compare September 2, 2025 18:40
@mattp0
Copy link
Contributor Author

mattp0 commented Sep 2, 2025

Draft state just want to get any early comments in if any

@mattp0 mattp0 force-pushed the mrp/feature/add-attribute-to-h5key branch 4 times, most recently from 0d3f96f to e584962 Compare September 2, 2025 23:47
@mattp0 mattp0 changed the title PR-7027 add h5 attribute syntax PR-7027 add h5 attribute syntax and bzip2 support Sep 2, 2025
@mattp0 mattp0 force-pushed the mrp/feature/add-attribute-to-h5key branch 8 times, most recently from ea76e42 to 97af525 Compare September 3, 2025 22:34
@mattp0 mattp0 marked this pull request as ready for review September 3, 2025 22:35
@mattp0 mattp0 requested a review from reweeden September 3, 2025 22:35
@mattp0
Copy link
Contributor Author

mattp0 commented Sep 3, 2025

Should this come after or before #47 ? I did run ruff on the files I touched... so I could see a conflict happening. but it might not be bad?

@reweeden
Copy link
Contributor

reweeden commented Sep 4, 2025

Should this come after or before #47 ? I did run ruff on the files I touched... so I could see a conflict happening. but it might not be bad?

Yea I saw that, that's why I made the PR actually. It would be best to make the ruff changes first before merging PRs that are reformatting unrelated code. Worth noting, you can run ruff on just a range of lines within a file so you can run it on just the lines you touched and not the rest of the file. That would also be fine, and is pretty easy to do if you're using the ruff language server in your editor since you can then just 'format selection'. Or you can just drop the unrelated changes from your commit after formatting the whole file.

@mattp0 mattp0 force-pushed the mrp/feature/add-attribute-to-h5key branch 3 times, most recently from 5986865 to e082e92 Compare September 4, 2025 22:24
@mattp0 mattp0 requested a review from reweeden September 5, 2025 20:41
@mattp0 mattp0 force-pushed the mrp/feature/add-attribute-to-h5key branch 3 times, most recently from 5d38e88 to a504fad Compare September 5, 2025 23:29
@mattp0 mattp0 force-pushed the mrp/feature/add-attribute-to-h5key branch from a504fad to e0aeb9a Compare September 5, 2025 23:40
@mattp0 mattp0 merged commit 3ec5be1 into main Sep 8, 2025
9 checks passed
@mattp0 mattp0 deleted the mrp/feature/add-attribute-to-h5key branch September 8, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants