-
Notifications
You must be signed in to change notification settings - Fork 0
PR-7027 add h5 attribute syntax and bzip2 support #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fdb368c to
819540a
Compare
|
Draft state just want to get any early comments in if any |
0d3f96f to
e584962
Compare
ea76e42 to
97af525
Compare
|
Should this come after or before #47 ? I did run ruff on the files I touched... so I could see a conflict happening. but it might not be bad? |
Yea I saw that, that's why I made the PR actually. It would be best to make the ruff changes first before merging PRs that are reformatting unrelated code. Worth noting, you can run ruff on just a range of lines within a file so you can run it on just the lines you touched and not the rest of the file. That would also be fine, and is pretty easy to do if you're using the ruff language server in your editor since you can then just 'format selection'. Or you can just drop the unrelated changes from your commit after formatting the whole file. |
5986865 to
e082e92
Compare
5d38e88 to
a504fad
Compare
a504fad to
e0aeb9a
Compare
Pull Request Checklist
I have: