build: make Version dynamic via ldflags (const → var)#453
Open
nlenepveu wants to merge 1 commit intoasheshgoplani:mainfrom
Open
build: make Version dynamic via ldflags (const → var)#453nlenepveu wants to merge 1 commit intoasheshgoplani:mainfrom
nlenepveu wants to merge 1 commit intoasheshgoplani:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Makefilealready setsLDFLAGS=-ldflags "-X main.Version=$(VERSION)"usinggit describe --tags, but this had no effect becauseVersionwas declared as aconst— Go's linker-Xflag only works on package-levelvars.As a result, every build (including official releases) always reports the hardcoded string (e.g.
v0.27.5) regardless of the actual tag or commit.Changes:
cmd/agent-deck/main.go:const Version = "..."→var Version = "..."(one character change)Makefile: strip the leadingvfromgit describeoutput so the injected value matches the existing"0.27.5"format and avoids a double-vprefix in the outputBefore:
After:
The default fallback value is unchanged — clean tag builds are unaffected.
Test plan
make build && ./build/agent-deck --versionon a clean tag checkout reportsvX.Y.ZvX.Y.Z-N-gSHAmake buildwith no git repo falls back todev