Fix #468: reset multi-repo state when reopening new session dialog#470
Draft
asheshgoplani wants to merge 1 commit intomainfrom
Draft
Fix #468: reset multi-repo state when reopening new session dialog#470asheshgoplani wants to merge 1 commit intomainfrom
asheshgoplani wants to merge 1 commit intomainfrom
Conversation
ShowInGroup() was missing the multi-repo field resets that other ephemeral fields (worktree, sandbox) already had. Once multi-repo mode was enabled, closing and reopening the dialog kept it checked with no visual way to uncheck it. Also fix the checkbox focus indicator so it shows as focused when multi-repo is enabled, making the space-to-uncheck action discoverable. Fixes #468 Committed by Ashesh Goplani
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShowInGroup()was missing multi-repo field resets (multiRepoEnabled,multiRepoPaths,multiRepoPathCursor,multiRepoEditing), causing multi-repo mode to persist across dialog reopensTest plan
TestNewDialog_ShowInGroup_ResetsMultiRepoverifies all 4 fields are resetFixes #468