Fix #472: use Kitty keyboard pop instead of push mode 0#473
Draft
asheshgoplani wants to merge 1 commit intomainfrom
Draft
Fix #472: use Kitty keyboard pop instead of push mode 0#473asheshgoplani wants to merge 1 commit intomainfrom
asheshgoplani wants to merge 1 commit intomainfrom
Conversation
DisableKittyKeyboard sent ESC[>0u (push mode 0) which on Ghostty activates CSI u encoding. Since Bubble Tea v1.3.10 doesn't parse CSI u, shifted keys were silently dropped. Changed to ESC[<u (pop) which safely disables any active Kitty mode without triggering CSI u encoding. Also fixes gofmt on conductor.go. Fixes #472 Committed by Ashesh Goplani
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DisableKittyKeyboardfromESC[>0u(push mode 0) toESC[<u(pop) ininternal/ui/keyboard_compat.goFixes #472