Fix one possibly typoed eq and test-error #1061
Conversation
ashinn
left a comment
ashinn
left a comment
There was a problem hiding this comment.
Thanks! Could you please mention both of these issues to the SRFI 64 list?
| ((test-runner-on-test-begin r) r) | ||
| (call-with-current-continuation | ||
| (lambda (k) | ||
| (with-exception-handler |
There was a problem hiding this comment.
Part just preference, when looking for exception handling I think I first came accross that code in R7RS pdf and I havent used guards. Part I think there was an implementation that did not work with guards on the other SRFI-64 implementation I linked. But I cant remember anymore if that was 100% the case. So in short skill issue. Thats why I opened an issue instead of pull request right away.
I can switch it to use guards if you want?
There was a problem hiding this comment.
Or perhaps it's best that I do some testing, if the call/cc version works on most/all implementations I will use that. If the guard version works on all I will use that because it's shorter. I will also report to the mailing list. You can leave this pull request open until I report back. That way the reference implementation wont be different from what is in Chibi.
There was a problem hiding this comment.
This fix does not fix things completely. I will close this pull request, make on for the eq -> eq? fix and then make new on for complete fix after I have made pull request to srfi-64 reference implementation.
2 participants
No description provided.