Open
Conversation
matthova
commented
Mar 15, 2019
| var bitwidth = options.bitwidth || '16'; | ||
| var encoding = options.encoding || 'signed-integer'; | ||
| var rate = options.rate || '16000'; | ||
| var bufferSize = options.bufferSize || '16384'; |
Author
There was a problem hiding this comment.
Because the buffer arg for arecord defaults to the min(max possible buffer size, 500ms), we can't determine an unopinionated default value.
One alternative is to remove defaults and only add the buffer argument if the bufferSize arg is passed.
Thoughts?
|
@ashishbajaj99 are you still maintaining this package? Is there anything I can help with to get this PR accepted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.