Skip to content

fix(test/win): platform-specific cold-start target (router)#49

Merged
masonwyatt23 merged 1 commit intomainfrom
fix/router-cold-start-windows-tolerance
Apr 29, 2026
Merged

fix(test/win): platform-specific cold-start target (router)#49
masonwyatt23 merged 1 commit intomainfrom
fix/router-cold-start-windows-tolerance

Conversation

@masonwyatt23
Copy link
Copy Markdown
Collaborator

Why

The router · cold-start latency test asserts median<300ms over 3 samples to catch perf regressions in the router. POSIX hosts comfortably hit ~70-100ms.

Hosted Windows runners are virtualized + antivirus-scanned, so bun child spawn cold-start can take well over 1s without any code change in the router. This causes intermittent flakes on Windows CI (saw 953ms median in PR #27's last run).

What

Splits the assertion target by platform:

  • POSIX: 300ms (unchanged — still tight enough to catch real regressions)
  • Windows: 1500ms (5x — still well below "regressed router" of ~3-4s on Windows)

Stats

  • POSIX local: median 71.9ms / 3 samples / 2 pass
  • Test still asserts "router did not double-spawn" (initial check) and bound the wall time

🤖 Generated with Claude Code

Hosted Windows runners are virtualized + antivirus-scanned, so bun child
spawn cold-start can take well over 1s without any actual code regression
in the router. Tightens POSIX bound (still 300ms) and uses a separate
1500ms bound on Windows that still catches genuine regressions (a regressed
router takes ~3-4s per run there).

Local POSIX: median 71.9ms over 3 samples (well under 300ms).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ashlr-plugin-site Ready Ready Preview, Comment Apr 29, 2026 6:55pm

Request Review

@masonwyatt23 masonwyatt23 merged commit fad77ab into main Apr 29, 2026
15 checks passed
@masonwyatt23 masonwyatt23 deleted the fix/router-cold-start-windows-tolerance branch April 29, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant