-
Notifications
You must be signed in to change notification settings - Fork 1
UI Improvements along with some updated logic. #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Improvements along with some updated logic. #31
Conversation
937a4e1 to
1ba9199
Compare
1ba9199 to
29f81e9
Compare
|
LGTM |
5ea86a8 to
e202819
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements UI improvements and updated logic for the SplitMySub application, focusing on enhanced payment management, automated reminder systems, and improved user experience.
- Payment workflow enhancements with new "mark as paid" functionality and improved status handling
- Automated reminder system implementation using SolidQueue with configurable billing cycles
- UI improvements including better select dropdown styling and enhanced payment status displays
Reviewed Changes
Copilot reviewed 22 out of 27 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/performance/n_plus_one_test.rb | Optimized query chain to reduce N+1 queries |
| test/integration/invitation_flow_test.rb | Updated HTTP status codes from unprocessable_entity to unprocessable_content |
| test/controllers/invitations_controller_test.rb | Updated HTTP status codes for consistency |
| docs/SELF_HOSTING.md | Added comprehensive documentation for automated reminder system |
| config/routes.rb | Added new route for mark_as_paid functionality |
| config/recurring.yml | Configured SolidQueue jobs for automated billing tasks |
| config/initializers/inertia_rails.rb | Enabled error hash inclusion in Inertia responses |
| app/models/payment.rb | Added null safety guards to payment status methods |
| app/models/billing_cycle.rb | Enhanced payment tracking and member status methods |
| app/models/billing_config.rb | Updated default due_soon_days configuration |
| app/frontend/routes/index.js | Updated Rails version reference |
| app/frontend/pages/*.svelte | Improved select dropdown styling across payment pages |
| app/controllers/payments_controller.rb | Added mark_as_paid functionality with authorization |
| app/controllers/invitations_controller.rb | Updated status codes to unprocessable_content |
| app/controllers/dashboard_controller.rb | Updated due_soon query to use configurable days |
| app/controllers/billing_cycles_controller.rb | Enhanced billing cycle properties and permissions |
| Gemfile | Updated inertia_rails gem version constraint |
| CLAUDE.md | Updated documentation for reminder system commands |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.