Add insensive HTTP header check per RFC 2616#23
Open
pjmolina wants to merge 1 commit intoasm89:masterfrom
Open
Add insensive HTTP header check per RFC 2616#23pjmolina wants to merge 1 commit intoasm89:masterfrom
pjmolina wants to merge 1 commit intoasm89:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFC 2616: header names are case insensitive, so the check:
smoke_assert_headers "content-type: application/json; charset=utf-8"should succeed when server returns the header names in any of these ways:
Content-Type: application/json; charset=utf-8content-type: application/json; charset=utf-8CoNTEnT-type: application/json; charset=utf-8etc...
Room for improvement:
The current implementation and the proposed fix is not splitting the header from the value.
So header value should be checked for differences in upper/lower case.