Skip to content

Optimize package store symlink creation #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
+13 −1
Open

Optimize package store symlink creation #2401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d073e3
Optimize package store symlink creation
dzbarsky Oct 18, 2025
a94a9ae
Merge branch '3.x' into zbarsky/symlink
dzbarsky Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion npm/private/npm_package_store.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ If set, takes precendance over the package version in the `NpmPackageInfo` src.
),
}

_PACKAGE_STORE_PREFIX_LEN = len("node_modules/" + utils.package_store_root)

def _npm_package_store_impl(ctx):
if ctx.attr.src:
if NpmPackageInfo in ctx.attr.src:
Expand Down Expand Up @@ -182,6 +184,10 @@ def _npm_package_store_impl(ctx):
if not version:
fail("No package version specified to link to. Package version must either be specified explicitly via 'version' attribute or come from the 'src' 'JsInfo|NpmPackageInfo', typically a 'js_library|npm_package' target")

package_store_prefix_len = _PACKAGE_STORE_PREFIX_LEN
if ctx.label.package:
package_store_prefix_len += len(ctx.label.package) + 1

package_key = "{}@{}".format(package, version)
package_store_name = utils.package_store_name(package_key)
package_store_directory = None
Expand Down Expand Up @@ -368,10 +374,16 @@ deps of npm_package_store must be in the same package.""" % (ctx.label.package,
actual_dep = deps_map[dep_ref_dep_key]
dep_ref_def_package_store_directory = actual_dep[NpmPackageStoreInfo].package_store_directory
if dep_ref_def_package_store_directory:
target = dep_ref_def_package_store_directory.short_path[package_store_prefix_len:]
for dep_ref_dep_alias in dep_ref_dep_aliases:
# "node_modules/{package_store_root}/{package_store_name}/node_modules/{package}"
dep_ref_dep_symlink_path = "node_modules/{}/{}/node_modules/{}".format(utils.package_store_root, dep_package_store_name, dep_ref_dep_alias)
files.append(utils.make_symlink(ctx, dep_ref_dep_symlink_path, dep_ref_def_package_store_directory.path))
symlink = ctx.actions.declare_symlink(dep_ref_dep_symlink_path)
ctx.actions.symlink(
output = symlink,
target_path = ("../../.." if "/" in dep_ref_dep_alias else "../..") + target,
)
files.append(symlink)
else:
# We should _never_ get here
fail("Internal error")
Expand Down
Loading