Blog-with-API--JulioMacíasCadera-RogerOlivéDelgado#51
Open
RogerOliveDelgado wants to merge 29 commits intoassembler-institute:mainfrom
Open
Blog-with-API--JulioMacíasCadera-RogerOlivéDelgado#51RogerOliveDelgado wants to merge 29 commits intoassembler-institute:mainfrom
RogerOliveDelgado wants to merge 29 commits intoassembler-institute:mainfrom
Conversation
alicembranos
left a comment
alicembranos
left a comment
There was a problem hiding this comment.
Perfect job and very clean code!!
| <title>Blog with API</title> | ||
| </head> | ||
| <body> | ||
| <main class="main__container"> |
There was a problem hiding this comment.
Improvement suggestion: Apply the principles of writing the attributes in order in HTML tags. https://github.com/necolas/idiomatic-html#attribute-order
| postsCont.addEventListener('click', (e) => { | ||
|
|
||
| if (e.target.hasAttribute('data-hide-comments')){ | ||
| const postId = e.target.getAttribute('data-show-comments') |
There was a problem hiding this comment.
Line 54 and 63 are repeated, maybe you can take it out the if else statement and put it at the beginning of the function.
| @@ -0,0 +1,19 @@ | |||
| .avatar{ | |||
There was a problem hiding this comment.
habeis utilizado nuevas técnicas en el css 👏🏻🥳
| @@ -0,0 +1,20 @@ | |||
| /*RESET*/ | |||
There was a problem hiding this comment.
| @@ -0,0 +1,186 @@ | |||
| //API url path | |||
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.