Solution_Adria_Valles_Jose_Cuevas#52
Open
jose-cuevas wants to merge 19 commits intoassembler-institute:mainfrom
Open
Solution_Adria_Valles_Jose_Cuevas#52jose-cuevas wants to merge 19 commits intoassembler-institute:mainfrom
jose-cuevas wants to merge 19 commits intoassembler-institute:mainfrom
Conversation
Jesusjha
reviewed
May 17, 2022
Comment on lines
+136
to
+137
| console.log(commentsTitle); | ||
| console.log(showComments); |
There was a problem hiding this comment.
Debugging tools could've been deleted
Jesusjha
reviewed
May 17, 2022
|
|
||
| commentsContainer.textContent = ""; | ||
| commentsBtn.style.display = "block"; | ||
| modalPosts.close(); |
Jesusjha
reviewed
May 17, 2022
Comment on lines
+71
to
+79
| async function fetchUsers(userId, postId) { | ||
| const userPromise = await fetch(`http://localhost:3000/users/${userId}`) | ||
| .then(function (response) { | ||
| return response.json(); | ||
| }) | ||
| .then(function (data) { | ||
| createPost(data, postId); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Good use of this function, it is easy to access to the data =)
Jesusjha
reviewed
May 17, 2022
| const postBody = document.createElement("p"); | ||
|
|
||
| const fetchPosts = fetch(`http://localhost:3000/posts/${postId}`); | ||
| fetchPosts |
There was a problem hiding this comment.
Not needed to declare it in a variable
Jesusjha
reviewed
May 17, 2022
Comment on lines
+117
to
+118
| const commentsBtn = document.getElementById("commentsBtn"); | ||
| const commentsContainer = document.getElementById("commentsContainer"); |
Jesusjha
reviewed
May 17, 2022
Comment on lines
+143
to
+145
| commentName.style.fontSize = "2rem"; | ||
| commentBody.style.fontSize = "1rem"; | ||
| userEmail.style.fontSize = "1rem"; |
There was a problem hiding this comment.
You could've added all styles from CSS and add classes from JS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.