Solution: Adrià Aparicio & Javier Fernández#55
Open
DogSoulDev wants to merge 22 commits intoassembler-institute:mainfrom
Open
Solution: Adrià Aparicio & Javier Fernández#55DogSoulDev wants to merge 22 commits intoassembler-institute:mainfrom
DogSoulDev wants to merge 22 commits intoassembler-institute:mainfrom
Conversation
Google Slides
Gaerste
reviewed
May 17, 2022
| <!-- Modal Post --> | ||
|
|
||
|
|
||
| <div class="modal fade" id="modal__wrapp" tabindex="-1" aria-labelledby="modal__wrapp" aria-hidden="true"> |
There was a problem hiding this comment.
Tags could be more semantic in the modal sections
Gaerste
reviewed
May 17, 2022
| .then(response => response.json()) | ||
| .then(data => data) | ||
| } | ||
|
|
Gaerste
reviewed
May 17, 2022
|
|
||
| function displayPost() { | ||
| getPost().then(dataPost => { | ||
| for(let i = 0; i < 20; i++) { |
Gaerste
reviewed
May 17, 2022
| } | ||
|
|
||
| // crear el plantilla del post html | ||
|
|
There was a problem hiding this comment.
A refactor with smaller functions might help structure and readability
Gaerste
reviewed
May 17, 2022
| @@ -0,0 +1,28 @@ | |||
| /* Event Modal | |||
There was a problem hiding this comment.
perhaps it would be better to pass the postStructure function in this file
Gaerste
reviewed
May 17, 2022
Gaerste
left a comment
Gaerste
left a comment
There was a problem hiding this comment.
files should be better organized and can be refactored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blog with API. All info on the .pdf
Thank you.