SOLUTION: Marcel Barreiro & Ricardo Vieira#56
Open
marcelbbarreiro wants to merge 12 commits intoassembler-institute:mainfrom
Open
SOLUTION: Marcel Barreiro & Ricardo Vieira#56marcelbbarreiro wants to merge 12 commits intoassembler-institute:mainfrom
marcelbbarreiro wants to merge 12 commits intoassembler-institute:mainfrom
Conversation
dariogmzfdz
reviewed
May 17, 2022
| </div> | ||
| </header> | ||
| <!-- Page content--> | ||
| <div id="container" class="container"> |
|
|
||
| postsContainer.appendChild(postsRow); | ||
| }) | ||
| } |
There was a problem hiding this comment.
It could have been split into a few js files
There was a problem hiding this comment.
Maybe a few more comments for a better organization of the code sections
| let myModal = document.getElementById("myModal"); | ||
| let modalTitle = document.getElementById('modalTitle'); | ||
| let modalBody = document.getElementById('modalBody'); | ||
|
|
| .then((data) => { | ||
| getUsers(data); | ||
| }) | ||
| .catch((error) => console.error(error)); |
There was a problem hiding this comment.
The console logs should be deleted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.