Skip to content

Solution: Victor Hugo Gomez#12

Open
labietelabiete wants to merge 4 commits intoassembler-institute:mainfrom
labietelabiete:main
Open

Solution: Victor Hugo Gomez#12
labietelabiete wants to merge 4 commits intoassembler-institute:mainfrom
labietelabiete:main

Conversation

@labietelabiete
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@Hugo05Duran Hugo05Duran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

Comment on lines -11 to -16
// page: 1,
// paginationInfo: null,
// episodes: [],
// hasLoaded: false,
// hasError: false,
// errorMessage: null,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments are necesary and must to delete it.

Comment on lines +35 to +38
if (prevPage !== page) {
this.loadEpisodes(page);
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well thought out and executed.

}

async loadEpisodes(page) {
console.log(this);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to delete all console log to avoid some messages in the dev tools.

return (
<Layout>
<section className="row">
{/* {hasLoaded && !hasError && (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detele comments.

<div className="col col-12">
<h1>Episodes loaded!</h1>
</div>
)} */}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detele comments.

<div className="col col-12">
<hr />
</div>
{/* {episodes.map((episode) => (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detele comments.

airDate={episode.air_date}
episode={episode.episode}
/>
))} */}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detele comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants