Solution : Jon Croatan - Einar#13
Open
einartech wants to merge 6 commits intoassembler-institute:mainfrom
Open
Solution : Jon Croatan - Einar#13einartech wants to merge 6 commits intoassembler-institute:mainfrom
einartech wants to merge 6 commits intoassembler-institute:mainfrom
Conversation
armandovieirag
left a comment
armandovieirag
left a comment
There was a problem hiding this comment.
logica muy bien implementada y codigo muy entendible, unico detalle dejarlo lo mas limpio posible al momento de push a main-produccion
Comment on lines
+45
to
+48
| console.log(name); | ||
| console.log(type); | ||
| console.log(dimension); | ||
| console.log(data); |
There was a problem hiding this comment.
tener cuidado con los console log en produccion(main), siempre hacer un repaso de los ficheros para dejarlo lo mas limpio posible
Comment on lines
103
to
105
| // locationN={locationN} | ||
| // locationD={locationD} | ||
| // locationT={locationT} |
There was a problem hiding this comment.
no dejar codigo comentado en la rama main, la misma sugerencia que lo de console
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.