Improves AbsoluteDate denormalization

src/Normalizer/AbsoluteDateNormalizer.php

@@ -6,9 +6,10 @@
 
 use AssoConnect\PHPDate\AbsoluteDate;
 use Symfony\Component\Serializer\Exception\InvalidArgumentException;
-use Symfony\Component\Serializer\Exception\NotNormalizableValueException;
+use Symfony\Component\Serializer\Exception\UnexpectedValueException;
 use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
+use Throwable;
 
 /**
  * Normalizes an instance of {@see AbsoluteDate} to a date string.
@@ -40,27 +41,27 @@
 
     /**
      * {@inheritdoc}
-     * @param mixed[] $context
      */
     public function supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool
     {
         return $data instanceof AbsoluteDate;
     }
 
     /**
      * {@inheritdoc}
-     *
-     * @param mixed[] $context
-     * @throws NotNormalizableValueException
      */
-    public function denormalize($data, string $type, ?string $format = null, array $context = []): ?AbsoluteDate
+    public function denormalize($data, string $type, ?string $format = null, array $context = []): AbsoluteDate
     {
+        if ('' === $data || null === $data) {
+            throw new UnexpectedValueException();
+        }
+
         $dateTimeFormat = $context[self::FORMAT_KEY] ?? AbsoluteDate::DEFAULT_DATE_FORMAT;
 
         try {
-            return '' === $data || null === $data ? null : new AbsoluteDate($data, $dateTimeFormat);
-        } catch (\Exception $e) {
-            throw new NotNormalizableValueException($e->getMessage(), $e->getCode(), $e);
+            return new AbsoluteDate($data, $dateTimeFormat);
+        } catch (Throwable $e) {
+            throw new UnexpectedValueException(previous: $e);
         }
     }
 
@@ -77,11 +78,8 @@
         return AbsoluteDate::class === $type;
     }
 
-    /**
-     * @return array<'*', bool>
-     */
     public function getSupportedTypes(?string $format): array
     {
-        return ['*' => false];
+        return [AbsoluteDate::class => true];
     }
 }

src/ThirdParty/Symfony/HttpKernel/Controller/ArgumentResolver/AbsoluteDateValueResolver.php

@@ -14,7 +14,7 @@
 class AbsoluteDateValueResolver implements ValueResolverInterface
 {
     /**
-     * @return array<AbsoluteDate>
+     * @return list<AbsoluteDate>
      */
     public function resolve(Request $request, ArgumentMetadata $argument): iterable
     {

tests/Normalizer/AbsoluteDateNormalizerTest.php

@@ -8,7 +8,6 @@
 use AssoConnect\PHPDateBundle\Normalizer\AbsoluteDateNormalizer;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Serializer\Exception\InvalidArgumentException;
-use Symfony\Component\Serializer\Exception\NotNormalizableValueException;
 use Symfony\Component\Serializer\Exception\UnexpectedValueException;
 
 class AbsoluteDateNormalizerTest extends TestCase
@@ -79,7 +78,7 @@ public function testDenormalizeInvalidDataThrowsException(): void
 
     public function testDenormalizeFormatMismatchThrowsException(): void
     {
-        $this->expectException(NotNormalizableValueException::class);
+        $this->expectException(UnexpectedValueException::class);
         $this->normalizer->denormalize('2016/01/01', AbsoluteDate::class, null, [
             AbsoluteDateNormalizer::FORMAT_KEY => 'Y-m-d|',
         ]);