Adding ssl option to config so users can silence warnings when connnecting to databases without SSL #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting to databases without SSL
NicoNekoDev
reviewed
Nov 5, 2020
| String database = configuration.getString("storage.mysql.database", "superbvote"); | ||
| String table = configuration.getString("storage.mysql.table", "superbvote"); | ||
| boolean readOnly = configuration.getBoolean("storage.mysql.read-only"); | ||
| boolean ssl = configuration.getBoolean("storage.mysql.ssl"); |
There was a problem hiding this comment.
I think here, the default value should be added as 'true' otherwise users without the config file updated, will not use SSL by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Sorry for any hiccups, this is my first time doing a pull request so I am learning.
The changes I've made allow for users to silence the following warnings that appear in console by setting 'ssl' to 'false' when they are using a database without SSL (like on a paid server host):
WARN: Establishing SSL connection without server's identity verification is not recommended. According to MySQL 5.5.45+, 5.6.26+ and 5.7.6+ requirements SSL connection must be established by default if explicit option isn't set. For compliance with existing applications not using SSL the verifyServerCertificate property is set to 'false'. You need either to explicitly disable SSL by setting useSSL=false, or set useSSL=true and provide truststore for server certificate verification.