Conversation
jinsun-yoo
requested review from
feris-amd,
tushar-krishna and
willjwon
as code owners
jinsun-yoo
force-pushed
the
yamlbuild
branch
from
dcb2e80 to
cc45f30
Compare
jinsun-yoo
changed the title
Collaborator
|
Updated the base branch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
developbranch is behindmain, hence landing onmain.The FetchContent syntax of CMake allows us to 1) link external repos without adding them as git submodules 2) define and link external repos in multiple places in multiple places without fear of overlapping.
Feature 2 allows us to include
yaml-cppin CMakeList.txt of both astra-sim and astra-network-analytical without collision