Closed
Conversation
Collaborator
Amos-Rai-KEYS
commented
Apr 14, 2026
Amos-Rai-KEYS
commented
- removing notebook tests files, since we are autogenerating them during tests.
Amos-Rai-KEYS
requested review from
harsh-sikhwal and
jinsun-yoo
as code owners
harsh-sikhwal
previously approved these changes
Apr 14, 2026
harsh-sikhwal
dismissed
their stale review
I think PR51 covers the removal of tests
jinsun-yoo
approved these changes
Apr 15, 2026
Contributor
jinsun-yoo
left a comment
jinsun-yoo
left a comment
There was a problem hiding this comment.
Perhaps a PR-on-PR gone wrong? In any case, this LGTM, but @Amos-Rai-KEYS do make sure the merge is done cleanly
Collaborator
Author
|
This PR is not required as PR51 covers the removal of tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.