Handle ICCCM TIMESTAMP selection target#167
Open
tricktron wants to merge 1 commit intoastrand:masterfrom
Open
Conversation
Respond to TIMESTAMP target requests with the real selection ownership timestamp as XA_INTEGER, and advertise TIMESTAMP in the TARGETS list. Acquire a real X server timestamp via zero-length property append and PropertyNotify instead of using CurrentTime in XSetSelectionOwner, fixing the ICCCM §2.1 violation noted in the existing FIXME comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #90
Fixes #92
Fixes #163
xclip was silently failing clipboard transfers for X11 consumers (VMware vmtoolsd, Citrix ICA, rdesktop) that send
TIMESTAMPtarget requests. This adds proper ICCCM TIMESTAMP support: real server timestamp acquisition viaPropertyNotifyand correctTIMESTAMPtarget responses.Testing