First Pass WCS extract region bound fix#882
Open
duytnguyendtn wants to merge 3 commits intoastropy:mainfrom
Open
First Pass WCS extract region bound fix#882duytnguyendtn wants to merge 3 commits intoastropy:mainfrom
duytnguyendtn wants to merge 3 commits intoastropy:mainfrom
Conversation
Contributor
Author
|
Poked around in SpectralGWCS, other than adjusting the size of the bounding box, I'm not sure if I can see a place where an equivalent slice would be appropriate, or even possible. I'm not sure, and the ticket #869 doesn't suggest, this problem exists with SpectralGWCS defined WCS's, so I'm going to mark this ready for review and request someone who knows better than I do clarify! |
Contributor
|
@duytnguyendtn I am not familiar with GWCS and have not tried to use spectral_slab on it. We can either:
|
Member
|
As discussed, if we want to revisit, the solution should adhere to APE 14 high-level API if possible. That way, it would naturally work for both FITS WCS and GWCS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #869
@PatrickOgle identified a bug in
extract_regionswhere the WCS wavelength reference value (CRVAL0) wasn't being updated to the new bounds of the extracted region. Implemented Patrick's solution in this PR. Still need to figure out what the appropriate solution would be for GWCS though...