Remove iOS 17 availability checks and keep else case #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinwongeecs
requested changes
Dec 11, 2025
| } else { | ||
| locationImage | ||
| } | ||
| locationImage |
Collaborator
There was a problem hiding this comment.
we should be keeping the condition with #available(iOS 17.0, *) instead of the the view in the else clause
Comment on lines
-31
to
-37
| if #available(iOS 17.0, *) { | ||
| listView | ||
| .contentMargins(.top, 0) | ||
| .contentMargins([.leading, .trailing], 5) | ||
| } else { | ||
| listView | ||
| } |
Comment on lines
-32
to
-39
| if #available(iOS 17.0, *) { | ||
| Map(bounds: MapCameraBounds(centerCoordinateBounds: mapRegion, minimumDistance: 2000)) { | ||
| SafetyMapMarker(safetyLog: selectedSafetyLog) | ||
| } | ||
| } else { | ||
| Map(coordinateRegion: .constant(mapRegion), annotationItems: [selectedSafetyLog]) { safetyLog in | ||
| MapPin(coordinate: safetyLog.coordinate) | ||
| } |
Comment on lines
-21
to
-28
| if #available(iOS 17.0, *) { | ||
| SafetyNewMapView(selectedSafetyLog: $selectedSafetyLog, | ||
| isShowingLegend: $isShowingLegend, | ||
| drawerViewState: $drawerViewState, | ||
| isPresentingDetailView: isPresentingDetailView) | ||
| } else { | ||
| oldMapView | ||
| } |
Comment on lines
-113
to
-120
| if #available(iOS 17.0, *) { | ||
| mapLegendButton | ||
| .contentTransition( | ||
| .symbolEffect(.replace) | ||
| ) | ||
| } else { | ||
| mapLegendButton | ||
| } |
Comment on lines
-55
to
-59
| .modify { | ||
| if #available(iOS 17.0, *) { | ||
| $0.scrollClipDisabled() | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
we should keep the .modify view modifier. Just have $0.scrollClipDisabled inside the .modify view modifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.