Conversation
Owner
asus4
commented
Apr 3, 2025
asus4
commented
- Closes Remove custom build post process for iOS XCFramework #57
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the custom post-process build functionality for xcframework integration and cleans up related documentation while updating dependency versions.
- Removed post-process build scripts for iOS in both the core and extensions packages.
- Removed README files in the optional packages that contained obsolete documentation.
- Updated version numbers in the root README.
Reviewed Changes
Copilot reviewed 23 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| com.github.asus4.onnxruntime/Editor/OrtPostProcessBuild.cs | Removed post-process build script for the core package. |
| com.github.asus4.onnxruntime.win-x64-gpu/README.md | Removed obsolete documentation for the Windows GPU package. |
| com.github.asus4.onnxruntime.unity/README.md | Removed obsolete documentation for the Unity utilities package. |
| com.github.asus4.onnxruntime.linux-x64-gpu/README.md | Removed obsolete documentation for the Linux GPU package. |
| com.github.asus4.onnxruntime-extensions/README.md | Removed obsolete documentation for the extensions package. |
| com.github.asus4.onnxruntime-extensions/Editor/OrtExtensionsPostProcessBuild.cs | Removed post-process build script for the extensions package. |
| README.md | Updated dependency versions across the project. |
Files not reviewed (12)
- com.github.asus4.onnxruntime-extensions/Editor/OrtExtensionsPostProcessBuild.cs.meta: Language not supported
- com.github.asus4.onnxruntime-extensions/Editor/com.github.asus4.onnxruntime-extensions.Editor.asmdef: Language not supported
- com.github.asus4.onnxruntime-extensions/Plugins/iOS.meta: Language not supported
- com.github.asus4.onnxruntime-extensions/Plugins/iOS/onnxruntime_extensions.xcframework.meta: Language not supported
- com.github.asus4.onnxruntime-extensions/package.json: Language not supported
- com.github.asus4.onnxruntime-genai/package.json: Language not supported
- com.github.asus4.onnxruntime.linux-x64-gpu/package.json: Language not supported
- com.github.asus4.onnxruntime.unity/package.json: Language not supported
- com.github.asus4.onnxruntime.win-x64-gpu/package.json: Language not supported
- com.github.asus4.onnxruntime/Editor/OrtPostProcessBuild.cs.meta: Language not supported
- com.github.asus4.onnxruntime/Editor/com.github.asus4.onnxruntime.Editor.asmdef: Language not supported
- com.github.asus4.onnxruntime/Plugins/Linux/x64/libonnxruntime.so.meta: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.